Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix options not used in star_mapping #30

Merged
merged 2 commits into from
Jul 10, 2023
Merged

Fix options not used in star_mapping #30

merged 2 commits into from
Jul 10, 2023

Conversation

cokelaer
Copy link
Contributor

@cokelaer cokelaer commented Jul 7, 2023

options from the star_mapping section in the config file was not used in the rule star_mapping

@cokelaer cokelaer requested review from khourhin and rania-o July 7, 2023 07:35
@cokelaer cokelaer force-pushed the main branch 4 times, most recently from dd5cfd7 to c5ef4e5 Compare July 7, 2023 12:10
khourhin
khourhin approved these changes Jul 7, 2023
View reviewed changes
README.rst Outdated Show resolved Hide resolved
@cokelaer cokelaer merged commit e4a31a1 into sequana:main Jul 10, 2023
3 of 5 checks passed
@coveralls
Copy link

Pull Request Test Coverage Report for Build 5506269905

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.4%) to 68.0%
Files with Coverage Reduction New Missed Lines %
sequana_pipelines/rnaseq/create_target.py 1 0%
Totals Coverage Status
Change from base Build 5187014397: -0.4%
Covered Lines: 272
Relevant Lines: 400
💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khourhin khourhin khourhin approved these changes

@rania-o rania-o rania-o approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@cokelaer @coveralls @khourhin @rania-o