Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return exit code 1 when undo migration failed #394

Closed
nehaabrol87 opened this issue Nov 28, 2016 · 4 comments
Closed

Return exit code 1 when undo migration failed #394

nehaabrol87 opened this issue Nov 28, 2016 · 4 comments

Comments

@nehaabrol87
Copy link

nehaabrol87 commented Nov 28, 2016

I see that exit code 1 is returned when a migration fails but same is not handled/returned when last migration is undone (undo).
I am using sequelize 1.9.2
Is there a reason why this is as is.

I see this was fixed #110 but the corresponding PR only catches errors for ups and not downs.

#161

@nehaabrol87
Copy link
Author

nehaabrol87 commented Nov 28, 2016

Oops I just noticed it exists in master.
Can you tell me which is the version where this first became available.I guess it is 2.3.0 but just wanted to confirm.
I guess this is not an issue then.

@AFBarstow
Copy link

I would like to +1/upvote getting cba03c8f pushed to a new release since not having this is quite painful for our application. Is there a rough-ish ETA when we can expect this commit in a release?

@gotrevor
Copy link

gotrevor commented Dec 6, 2016

This has also been requested over here: #374

@sushantdhiman sushantdhiman mentioned this issue Sep 1, 2017
@sushantdhiman
Copy link
Contributor

480f3fc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants