db:migrate returns status code 0 when migration fails

[renou]

Migration failures on db level are not handled properly and the command returns success code 0 and prints

Using environment 'development'.
== 20150318142814-init: migrating =======
Possibly unhandled SequelizeDatabaseError: type "enum_Group_status" already exists

[sdepold]

It would be nice if you could create a test as a pull request that shows the failing behavior. Otherwise I'll try to take a look at it at some point.

[renou]

var sh = require('execSync');
var result = sh.exec('node_modules/.bin/sequelize db:migrate');
if(result.code === 0 && result.stdout.indexOf('SequelizeDatabaseError') > -1) {
  console.error('result has SequelizeDatabaseError but return code is 0');
  throw new Error(result.stdout);
} else {
  console.info(result.stdout);
}

you can run this with a migration that will fail (duplicate table, duplicate type...).

[theazureshadow]

+1. We need to fail deployments that didn't migrate correctly, and without an exit code our deployment scripts can't tell that they failed.

[arturhtml]

+1

[sorin]

+1

[sdepold]

fixed in 1.7.4