Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lean Build #369

Merged
merged 2 commits into from Oct 5, 2016
Merged

Lean Build #369

merged 2 commits into from Oct 5, 2016

Conversation

sushantdhiman
Copy link
Contributor

@sushantdhiman sushantdhiman commented Oct 5, 2016 •
edited

Closes #348

felixfbecker
felixfbecker reviewed Oct 5, 2016
View reviewed changes
.travis.yml
- JS2COFFEE=2.0.0 DIALECT=sqlite SEQUELIZE=2.1.3
- JS2COFFEE=2.0.0 DIALECT=sqlite SEQUELIZE=3.22.0

- JS2COFFEE=2.0.0 DIALECT=mysql SEQUELIZE=3.24.3
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could just use a devDep then

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really dont want to restart the build for this change :)

@sushantdhiman sushantdhiman merged commit 733b71e into master Oct 5, 2016
@sushantdhiman sushantdhiman deleted the drop-build branch October 5, 2016 18:54
@sdepold
Copy link
Member

sdepold commented Oct 11, 2016

👍

@sushantdhiman sushantdhiman mentioned this pull request Oct 29, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felixfbecker felixfbecker felixfbecker left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sushantdhiman @sdepold @felixfbecker