Fix custom config path not being resolved #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The config path will now be resolved relative to process.cwd().
|
I wonder if this could need a test ? |
|
Yes, it definitely needs one. I tried but I found it quite hard to add new tests. I think I'm going to need assistance :-) |
|
Hey :) I just merged my test refactoring and wonder if it is now easier for you to add some |
|
guess i will write the test on my own and you could check them out afterwards and probably get an idea of how to write them in future PRs. |
|
Excellent pick btw. I had tests for that but they were stupid :D |
|
Will do! Thanks for adding the tests! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The config path will now be resolved relative to process.cwd().