Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to db:migrate:undo:all which allows reverting migration to a specific version. #459

Merged

Conversation

kristijanhusak
Copy link
Contributor

Add option to undo migrations to the specific version.
https://github.com/sequelize/umzug#reverting-executed-migration

This option is very useful when continuous integration is used, since it allows easier rolling back in case something went wrong.

@mention-bot
Copy link

@kristijanhusak, thanks for your PR! By analyzing the history of the files in this pull request, we identified @Americas, @leebenson and @fossamagna to be potential reviewers.

Copy link
Collaborator

@Americas Americas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a nifty little feature. But can you add some tests to make sure that it runs as expected?

@kristijanhusak
Copy link
Contributor Author

@Americas I added the test. I haven't run the whole suite, just that single one, since it is taking too long to finish.

@Americas
Copy link
Collaborator

test/db/migrate/undo/all_to.test.js: line 48, col 115, Line is too long.

@kristijanhusak kristijanhusak force-pushed the feature/migrate-undo-all-to-migration branch from 7956b48 to 2b3a35f Compare June 4, 2017 18:52
@Americas Americas merged commit 88441ef into sequelize:master Jun 14, 2017
@kristijanhusak kristijanhusak deleted the feature/migrate-undo-all-to-migration branch June 14, 2017 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants