Added --from and --to support for db:migrate #581
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
test/db/migrate.test.js
Outdated
| expect(tables).to.have.length(3); | ||
| expect(tables).to.contain('User'); | ||
| runCli('db:migrate --to ' + createTriggers, err => { | ||
| done(err); |
There was a problem hiding this comment.
For proper verification, check for containment of No migrations were executed, database schema was already up to date. and error code 0 here
|
@sushantdhiman Extended tests to include what you requested |
test/db/migrate.test.js
Outdated
| expect(tables).to.contain('Post'); | ||
| expect(tables).to.contain('trigger_test'); | ||
| runCli('db:migrate --from ' + createPost, err => { | ||
| done(err); |
There was a problem hiding this comment.
Please add same check here
|
@sushantdhiman I haven't initially added checks for --from migrations because it wasn't throwing any errors unlike --to. Latest commit introduces that check too |
sushantdhiman
approved these changes
Nov 17, 2017
sushantdhiman
added a commit
that referenced
this pull request
Dec 3, 2017
This reverts commit 4a7e6c4.
codetriage-readme-bot
pushed a commit
to codetriage-readme-bot/cli
that referenced
this pull request
Jun 5, 2019
Move API error handling into the commands
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enables underlying umzug functionality