Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(db:create): support options on db:create with sequelize@4 #700

Merged
merged 3 commits into from
Oct 20, 2018
Merged

feat(db:create): support options on db:create with sequelize@4 #700

merged 3 commits into from
Oct 20, 2018

Conversation

ALiangLiang
Copy link
Contributor

same as #699
But it's a patch with sequelize@4. No create/dropDatabase used.

resolved #698
resolved #590
resolved #629

@sushantdhiman sushantdhiman merged commit aedca52 into sequelize:master Oct 20, 2018
@sushantdhiman
Copy link
Contributor

sushantdhiman commented Oct 20, 2018 •
edited
Loading

Thanks @ALiangLiang

Edit: Released as 5.2.0

@Bossorcain
Copy link

Bossorcain commented Apr 12, 2023 •
edited
Loading

Hello!

This change does not resolved #629 - can you check it please? (See my and other's comment in the mentioned thread. Thx!)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sushantdhiman sushantdhiman sushantdhiman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@ALiangLiang @sushantdhiman @Bossorcain