remove side effect in Util.format to fix bug `some function will modi…

…fy passed arguments`.
sequelize · Sep 15, 2013 · 5da0c23 · 5da0c23
1 parent 253b149
commit 5da0c23
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/lib/dialects/postgres/query-generator.js b/lib/dialects/postgres/query-generator.js
@@ -547,7 +547,7 @@ module.exports = (function() {
         result = smth
       }
       else if (Array.isArray(smth)) {
-        result = Utils.format(smth.slice(0), "postgres")
+        result = Utils.format(smth, "postgres")
       }
 
       return result

diff --git a/lib/utils.js b/lib/utils.js
@@ -55,7 +55,7 @@ var Utils = module.exports = {
   },
   format: function(arr, dialect) {
     var timeZone = null;
-    return SqlString.format(arr.shift(), arr, timeZone, dialect)
+    return SqlString.format(arr[0], arr.slice(1), timeZone, dialect)
   },
   formatNamedParameters: function(sql, parameters, dialect) {
     var timeZone = null;