Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disconnect hooks #11117

Merged
merged 3 commits into from
Jun 28, 2019
Merged

disconnect hooks #11117

merged 3 commits into from
Jun 28, 2019

Conversation

UziTech
Copy link
Contributor

@UziTech UziTech commented Jun 26, 2019

Pull Request check-list

Please make sure to review and check all of these items:

  • Does npm run test or npm run test-DIALECT pass with this change (including linting)?
  • Does the description below contain a link to an existing issue (Closes #[issue]) or a description of the issue you are solving?
  • Have you added new tests to prevent regressions?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Did you follow the commit message conventions explained in CONTRIBUTING.md?

Description of change

Add hooks that run before and after disconnecting a connection:

  • beforeDisconnect
  • afterDisconnect

@codecov
Copy link

codecov bot commented Jun 26, 2019

Codecov Report

Merging #11117 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #11117      +/-   ##
==========================================
+ Coverage   96.34%   96.34%   +<.01%     
==========================================
  Files          94       94              
  Lines        9009     9011       +2     
==========================================
+ Hits         8680     8682       +2     
  Misses        329      329
Impacted Files Coverage Δ
lib/hooks.js 96.96% <ø> (ø) ⬆️
lib/sequelize.js 95.91% <ø> (ø) ⬆️
lib/dialects/abstract/connection-manager.js 90.51% <100%> (+0.16%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 89802e0...ea4d418. Read the comment docs.

@UziTech UziTech marked this pull request as ready for review June 27, 2019 16:50
@UziTech UziTech changed the title [WIP] disconnect hooks disconnect hooks Jun 27, 2019
@sushantdhiman sushantdhiman merged commit 7a6cc32 into sequelize:master Jun 28, 2019
@sushantdhiman
Copy link
Contributor

🎉 This PR is included in version 5.9.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

schmod pushed a commit to schmod/sequelize that referenced this pull request Jul 10, 2019
…ndle-deadlock

* 'master' of github.com:sequelize/sequelize: (22 commits)
  docs(migrations): use timestamps with seed (sequelize#11160)
  test: remove redundant test (sequelize#11156)
  fix(types): add literal to possible where options (sequelize#10990)
  fix(model): don't alter original scopes when combining them (sequelize#10722)
  fix(types): relax order typing (sequelize#10802)
  fix(types): add string to Includeable (sequelize#11003)
  docs(models-definition): correct spelling mistakes (sequelize#11147)
  fix(types): silent option for update (sequelize#11115)
  fix: update sequelize-pool (sequelize#11134)
  feat(hooks): beforeDisconnect / afterDisconnect (sequelize#11117)
  refactor: remove unused _templateSettings
  refactor(query-generation): remove lodash string templates (sequelize#11122)
  docs: improve datatype docs
  docs: explain defaults/where behavior for find/create (sequelize#11069)
  build: remove test*.js from .gitignore (sequelize#11108)
  docs(data-types): extending types
  fix(sequelize.close): update sequelize-pool (sequelize#11101)
  build: update dependencies (sequelize#11099)
  docs(migrations): foreign key example (sequelize#11097)
  fix(mariadb): properly escape json path key (sequelize#11089)
  ...
@UziTech UziTech deleted the disconnect-hooks branch July 22, 2019 16:12
@sushantdhiman
Copy link
Contributor

🎉 This PR is included in version 7.0.0-next.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants