-
-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Add support for Oracle DB 18c CI #15016
Conversation
* feat(oracle): add oracle dialect support
* fix: addressing review comments
* fix: minor fixes to the review comments
* fix: doc gen is fixed
* fix: autogenerate the primary constraint name
populateInsertQueryReturnIntoBinds
* fix: incorporated review comments
Hm. Seems the failing tests are consistent across the both oracle versions? |
The tests that failed in the CI are flaky; they should be fixed with a re-run. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have a few comments but they are non blocking. Would be nice if you could work on these
There has been a flaky failure in 2 DBs, it would be good to re-run to failed jobs. Thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One more comment, but I think after that we should be good to merge
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me. I do have some points for additional refactor but I'll take those up as part of backporting CI changes that we've done on main
to v6
.
Thanks for your work on this!
🎉 This PR is included in version 6.23.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Pull Request Checklist
Description Of Change
PR to support the CI of the minimal supported Oracle DB version
Todos