Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sqlite/query-generator): support restart identity in SQLite #10522

Merged
merged 3 commits into from Mar 9, 2019

Conversation

2 participants
@SavageCore
Copy link
Contributor

SavageCore commented Mar 8, 2019

Pull Request check-list

Please make sure to review and check all of these items:

  • Does npm run test or npm run test-DIALECT pass with this change (including linting)?
  • Does the description below contain a link to an existing issue (Closes #[issue]) or a description of the issue you are solving?
  • Have you added new tests to prevent regressions?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Did you follow the commit message conventions explained in CONTRIBUTING.md?

Description of change

Follow-up to #5356 adding support for SQLite.

npm run test-sqlite passes and I also tested the generated SQL against my DB

I believe current docs suffice?

Show resolved Hide resolved lib/dialects/sqlite/query-generator.js Outdated
@codecov

This comment has been minimized.

Copy link

codecov bot commented Mar 9, 2019

Codecov Report

Merging #10522 into master will increase coverage by 0.04%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #10522      +/-   ##
==========================================
+ Coverage   96.14%   96.18%   +0.04%     
==========================================
  Files          92       92              
  Lines        9500     9026     -474     
==========================================
- Hits         9134     8682     -452     
+ Misses        366      344      -22
Impacted Files Coverage Δ
lib/dialects/sqlite/query-generator.js 96.34% <100%> (ø) ⬆️
lib/data-types.js 91.25% <0%> (-3.13%) ⬇️
lib/dialects/postgres/data-types.js 96.26% <0%> (-1.46%) ⬇️
lib/utils.js 98.34% <0%> (-0.02%) ⬇️
lib/associations/has-many.js 97.59% <0%> (ø) ⬆️
lib/utils/inherits.js
lib/utils/classToInvokable.js 100% <0%> (ø)
lib/model.js 96.66% <0%> (ø) ⬆️
lib/query-interface.js 92.21% <0%> (+0.32%) ⬆️
lib/associations/belongs-to-many.js 97.93% <0%> (+0.34%) ⬆️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0b5aa71...8607f32. Read the comment docs.

@sushantdhiman sushantdhiman merged commit 0c68590 into sequelize:master Mar 9, 2019

1 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.