feat(sqlite/query-generator): support restart identity in SQLite - #10522
Merged
sushantdhiman merged 3 commits intoMar 9, 2019
Merged
Conversation
sushantdhiman
suggested changes
Mar 9, 2019
Codecov Report
@@ Coverage Diff @@
## master #10522 +/- ##
==========================================
+ Coverage 96.14% 96.18% +0.04%
==========================================
Files 92 92
Lines 9500 9026 -474
==========================================
- Hits 9134 8682 -452
+ Misses 366 344 -22
Continue to review full report at Codecov.
|
sushantdhiman
approved these changes
Mar 9, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request check-list
Please make sure to review and check all of these items:
npm run testornpm run test-DIALECTpass with this change (including linting)?Description of change
Follow-up to #5356 adding support for SQLite.
npm run test-sqlitepasses and I also tested the generated SQL against my DBI believe current docs suffice?