Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(typescript): correct misspelling of associations #10707

Merged
merged 2 commits into from
Apr 8, 2019

Conversation

abernix
Copy link
Contributor

@abernix abernix commented Apr 5, 2019

Description of change

This changes two occurrences of associtations (note the extra t).

I figure if this isn't corrected, this typo will slowly seep into the
various implementations (like end-users like myself) who are copying and
pasting examples from the documentation into their own projects. 馃槃

This changes two occurrences of `associtations` (note the extra `t`).

I figure if this isn't corrected, this typo will slowly seep into the
various implementations (like end-users like myself) who are copying and
pasting examples from the documentation into their own projects. :)
@arnavb
Copy link

arnavb commented Apr 5, 2019

Oh wow! Looks like we both found the same error and opened a PR (mine is #10713). Since yours is more complete, I will close mine.

@arnavb arnavb mentioned this pull request Apr 5, 2019
@sushantdhiman
Copy link
Contributor

Typing tests are breaking

This fixes the (correct!) test failures exhibited on the referenced PR
below.

Ref: sequelize#10707
@codecov
Copy link

codecov bot commented Apr 8, 2019

Codecov Report

Merging #10707 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #10707   +/-   ##
=======================================
  Coverage    96.3%    96.3%           
=======================================
  Files          93       93           
  Lines        8976     8976           
=======================================
  Hits         8644     8644           
  Misses        332      332

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update b6c9117...380c237. Read the comment docs.

@abernix
Copy link
Contributor Author

abernix commented Apr 8, 2019

@sushantdhiman I've added a follow-up commit which I believe to be the correct adjustment in docs-example.ts (and proper fix for a previously incorrect reference which is now surfaced because of the typing which this PR corrects!).

Tests are passing now!

@sushantdhiman sushantdhiman merged commit 57aba97 into sequelize:master Apr 8, 2019
@sushantdhiman
Copy link
Contributor

馃帀 This PR is included in version 5.2.13 馃帀

The release is available on:

Your semantic-release bot 馃摝馃殌

@abernix abernix deleted the abernix/associtations branch April 8, 2019 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants