Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(types): fix findAll() being treated as raw #14668

Merged
merged 3 commits into from
Jun 26, 2022
Merged

Conversation

ephys
Copy link
Member

@ephys ephys commented Jun 21, 2022

#12921 introduced a regression where findAll() without any parameter was understood as findAll({ raw: true }) by TypeScript.

This PR fixes that

@ephys ephys added the type: typescript For issues and PRs. Things that involve typescript, such as typings and intellisense. label Jun 21, 2022
@ephys ephys self-assigned this Jun 21, 2022
Copy link
Member

@WikiRik WikiRik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I should stop approving things if the tests look good but then fail 😅

@ephys
Copy link
Member Author

ephys commented Jun 21, 2022

I should run tests before I send my PRs :D

@WikiRik WikiRik merged commit 06f4429 into main Jun 26, 2022
@WikiRik WikiRik deleted the ephys/fix-find-all-typing branch June 26, 2022 18:11
@github-actions
Copy link
Contributor

github-actions bot commented Aug 7, 2022

🎉 This PR is included in version 7.0.0-alpha.15 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released on @v7 type: typescript For issues and PRs. Things that involve typescript, such as typings and intellisense.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants