Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

meta: use start scripts for mysql/mariadb in CI #15300

Merged
merged 3 commits into from
Nov 19, 2022
Merged

Conversation

WikiRik
Copy link
Member

@WikiRik WikiRik commented Nov 18, 2022

Pull Request Checklist

  • Have you added new tests to prevent regressions?
  • If a documentation update is necessary, have you opened a PR to the documentation repository?
  • Did you update the typescript typings accordingly (if applicable)?
  • Does the description below contain a link to an existing issue (Closes #[issue]) or a description of the issue you are solving?
  • Does the name of your PR follow our conventions?

Description Of Change

This PR changes the CI so it uses the start scripts for MariaDB and MySQL. The latest version of this is automatically updated by renovate so that limits the manual work we need to do.

@WikiRik WikiRik marked this pull request as ready for review November 18, 2022 21:30
@WikiRik
Copy link
Member Author

WikiRik commented Nov 18, 2022

I don't think we want to do anything about the usage of MySQL 5.7.8 instead of 5.7.0, but we should look into the test for MariaDB 10.9/10.10. It seems to store the model correctly but it can't query on the $$ it seems. Something related to jsonPathExtractionQuery probably. But that's not for this PR

@WikiRik WikiRik requested a review from a team November 18, 2022 22:40
@WikiRik WikiRik merged commit 83405f7 into main Nov 19, 2022
@WikiRik WikiRik deleted the WikiRik/ci-mariadb-mysql branch November 19, 2022 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants