fix(scope): do not assign scope on eagerly loaded associations - #9292
Merged
sushantdhiman merged 1 commit intoApr 13, 2018
Merged
Conversation
verdier
force-pushed
the
fixAssociationScopeAssignation
branch
from
April 12, 2018 11:06
14f7630 to
92ecf72
Compare
verdier
added a commit
to dougs-compta/sequelize
that referenced
this pull request
Apr 12, 2018
verdier
force-pushed
the
fixAssociationScopeAssignation
branch
from
April 12, 2018 12:47
92ecf72 to
0d069bf
Compare
verdier
added a commit
to dougs-compta/sequelize
that referenced
this pull request
Apr 12, 2018
sushantdhiman
left a comment
sushantdhiman
left a comment
Contributor
There was a problem hiding this comment.
LGTM, a few suggestions for tests
| }); | ||
| }); | ||
| it('should include associations with operator scope values', function() { | ||
| const self = this; |
Contributor
There was a problem hiding this comment.
No need for self with arrow functions
| type: 'green' | ||
| }) | ||
| ); | ||
| }).bind(this).spread(function(post, commentA, commentB, commentC) { |
verdier
force-pushed
the
fixAssociationScopeAssignation
branch
from
April 13, 2018 08:24
0d069bf to
5b5f6b6
Compare
Contributor
Author
|
@sunshinewyin done ^^ |
sushantdhiman
approved these changes
Apr 13, 2018
verdier
added a commit
to dougs-compta/sequelize
that referenced
this pull request
Nov 20, 2018
verdier
added a commit
to dougs-compta/sequelize
that referenced
this pull request
Jul 16, 2019
fix(model): fix a bug with findSeparate docs(packages): Bump version fix(scope): backport sequelize#9292 fix(core): Fix nested savepoints Bump version
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request check-list
Please make sure to review and check all of these items:
npm run testornpm run test-DIALECTpass with this change (including linting)?Description of change
Fix an issue introduced by #9127 when eager loading association with complex scope, such as:
When assigning the scope to the instance in
_setInclude, the instance's propertytypebecamecomment.type === { [Op.in]: ['blue', 'green'] }.This fix move the assignation of the association scope only on creation.