Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TypeScript rewrite #209

Merged
merged 44 commits into from
Apr 5, 2020
Merged

TypeScript rewrite #209

merged 44 commits into from
Apr 5, 2020

Conversation

papb
Copy link
Member

@papb papb commented Apr 5, 2020

  • Full TypeScript rewrite, except for the tests
    • We now have our own TypeScript typings, so no need for @types/umzug anymore
  • Use XO as linter
  • Use AVA for new tests
    • One day we shall move the old tests from mocha to AVA + TypeScript as well
  • Remove Bluebird entirely
  • Almost no breaking changes (the tests are almost the same!)
    • BREAKING: You now have to use const { Umzug } = require('umzug') instead of const Umzug = require('umzug') - this is probably the only truly relevant breaking change
    • Breaking: removed Bluebird so you can no longer use things like .tap directly on the Promise returned by some umzug method (you will have to wrap it first)
    • Breaking: renamed Storage to NoneStorage (I doubt anyone uses this though)
    • Breaking: removed the already deprecated old Umzug Storage constructor

@papb papb merged commit f56fb5d into master Apr 5, 2020
@papb papb deleted the typescript branch April 20, 2020 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant