Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This switches from nodejs's
EventEmitter
to emittery for a few reasons:.on('migration', ...)
instead of.on('migrating', ...)
etc. It also types the event payload - especially important now since the payload is changing slightlythis.emit(...)
now returns a promise, which we can await. Which means in a follow-up, we can addbeforeAll
andafterAll
events, which will enable use cases like locking the migration table. That wouldn't be possible with sync events.The API is smaller than
EventEmitter
which makes this a breaking change by itself.emittery
only supports single payloads too, meaning we can no longeremit('migrating', m.name, m)
- but that was pretty redundant anyway, so it makes sense to update toMigrationParams
as part of the major (v3) release.