Add beforeAll/afterAll events + file locking #397
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #394
This adds
beforeAll
andafterAll
events. They run before the first and after the last migration respectively, for bothup
anddown
calls. This allows for locking functionality as requested in #144. Right now, there's aFileLocker
class which uses the filesystem to implement a very basic locking mechanism. Adding actual database locking is more complex though, since every database system implements locks differently. I plan to use this to add locking to @slonik/migrator, since that's postgresql-only. It might be possible to add aSequelizeLocker
class similar toFileLocker
using transactions, but if that's difficult it could come in another follow-up. @papb have you use sequelize locks before?