Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): update dependency pony-cause to v2.1.10 #616

Merged
merged 1 commit into from
Jan 31, 2024

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Aug 7, 2023

Mend Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
pony-cause 2.1.4 -> 2.1.10 age adoption passing confidence

Release Notes

voxpelli/pony-cause (pony-cause)

v2.1.10

Compare Source

  • Maintenance release, no functional changes

v2.1.9

Compare Source

  • Maintenance release, no functional changes

v2.1.8

Compare Source

  • Fix published types and the type building in published types test (#​62) 0296862 (Sorry, this one fooled me a couple of times)
  • Improve README 7d1d509

v2.1.7

Compare Source

  • Fix verification of published types + fix regression in types for some setups with TypeScript 4.6 and 4.7 (#​61) 68fbc45

v2.1.6

Compare Source

  • Fix for adding types to exports in package.json f6c2e09

v2.1.5

Compare Source

  • Add types to exports in package.json f6c2e09

No changes from v2.1.5-0


Configuration

📅 Schedule: Branch creation - "before 3am on Monday" (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

@codecov
Copy link

codecov bot commented Aug 7, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (fc6ba00) 98.90% compared to head (909525b) 98.90%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #616   +/-   ##
=======================================
  Coverage   98.90%   98.90%           
=======================================
  Files          12       12           
  Lines        1459     1459           
  Branches      260      260           
=======================================
  Hits         1443     1443           
  Misses         16       16           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@renovate renovate bot force-pushed the renovate/pony-cause-2.x-lockfile branch 12 times, most recently from 879f997 to b3513d1 Compare November 6, 2023 16:43
@renovate renovate bot force-pushed the renovate/pony-cause-2.x-lockfile branch 2 times, most recently from 09a369c to c9acd4b Compare December 8, 2023 01:08
@renovate renovate bot force-pushed the renovate/pony-cause-2.x-lockfile branch 2 times, most recently from 815ee7a to f638dd8 Compare December 18, 2023 07:53
@renovate renovate bot force-pushed the renovate/pony-cause-2.x-lockfile branch 4 times, most recently from f75a863 to 3bd1d43 Compare January 20, 2024 15:26
@renovate renovate bot force-pushed the renovate/pony-cause-2.x-lockfile branch 4 times, most recently from 9b978e7 to bfa6907 Compare January 30, 2024 16:20
@voxpelli
Copy link

Something I can do to help get this merged? / Sincerely the author of pony-cause

@renovate renovate bot force-pushed the renovate/pony-cause-2.x-lockfile branch from bfa6907 to 909525b Compare January 31, 2024 13:06
@mmkal mmkal merged commit fcb03a6 into main Jan 31, 2024
8 checks passed
@mmkal mmkal deleted the renovate/pony-cause-2.x-lockfile branch January 31, 2024 13:50
@mmkal
Copy link
Contributor

mmkal commented Jan 31, 2024

Thanks for the bump! I was thinking about removing pony-cause in the next major version since modern nodejs has it built in. Do you think there's any reason to keep it around if there's an engines making sure it's supported natively? No timeline on a major release, just curious.

@voxpelli
Copy link

voxpelli commented Jan 31, 2024

@mmkal Depends on whether you are using any of the helpers it provides or merely using the ponyfill

The helpers can be quite useful and is a modern interpretation of some of the ones that VError used to ship with:

  • findCauseByReference - finding an error of a specific type within the cause chain
  • messageWithCauses - gets the error message with the messages of its cause chain appended to it
  • stackWithCauses - gets a stack trace for the error + all its causes

Especially findCauseByReference is helpful, especially if one eg. needs to look at a Postgres error that's been wrapped by a non-Postgres error – it finds the correct one and provides the correct type for it

Copy link

Released in v3.6.0.

@mmkal
Copy link
Contributor

mmkal commented Jan 31, 2024

@mmkal Depends on whether you are using any of the helpers it provides or merely using the ponyfill

The helpers can be quite useful and is a modern interpretation of some of the ones that VError used to ship with:

  • findCauseByReference - finding an error of a specific type within the cause chain
  • messageWithCauses - gets the error message with the messages of its cause chain appended to it
  • stackWithCauses - gets a stack trace for the error + all its causes

Especially findCauseByReference is helpful, especially if one eg. needs to look at a Postgres error that's been wrapped by a non-Postgres error – it finds the correct one and provides the correct type for it

Ah, nice, had forgotten pony-cause is where those live. umzug doesn't use any right now, but they make a ton of sense for application code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants