Win 10 path missing a slash

[Samzyre]

Describe the bug
Local cargo index git path The error message is missing some backslashes.

To Reproduce
When I have useLocalCargoIndex set to true, I get this error:

**clap: Error: Command failed: git --no-pager --git-dir="C:\Users\Samz.cargo\registry\index\github.com-1ecc6299db9ec823.git" show origin/master:cl/ap/clap fatal: invalid object name 'origin/master'. ** ( Check Reviews )

Expected behavior
The user dir is faultly Samz.cargo and should be Samz\.cargo, and github.com-1ecc6299db9ec823.git should have \.git

Desktop (please complete the following information):

• OS: Windows
• Version: 10.0.19042

Additional context
Seems to be the case in 0.5.6 and 0.5.7 (not sure why it worked until 0.5.7 update tho)
Perhaps related to this #116 ?

EDIT: Corrected some details about the issue, also see my comment

[Samzyre]

Node version v14.16.0 (if it helps)

[Samzyre]

Setting localCargoIndexBranch to origin/HEAD (like it's in the description) instead of origin/master (default) also solves the error. So maybe that's the actual problem since I read that the error message might have dropped a backslash in markdown.

[char-name]

I had the same problem and it didn't work after setting local Cargo Index Branch, I solved it by deleting ~/.cargo/registry and regenerating it again

[MeerMusik]

Same Issue here. Manually deleting the Cargo.Registry Directory solves it for a moment. But as soon as I change cargo.toml everything breaks again: Just re-saving cargo.toml without any changes at all is enough.

System:
Windows 10 20H2, x86_64
Visual Studio Code 1.54.3 (but also already existed in atleast 1.54.2)
Crates Version: 0.5.7

Potential Issue: Crates and the Local Cargo Index do not like each other. I have now DISABLED "Use Local Cargo Index", restarted VS Code a couple times and also recreated the Cargo Registry multiple times. Crates for works now.

BTW: Thanks for this Extension. Nice little helper :)

[serayuzgur]

@MeerMusik Thanks. It is just getting more complex for me. Two different group of users have different opinions about / , please help me to fix this issue with a PR. I don't have a windows system and need someone to test it at least 2 version of windows (7, 10 for ex.).

[MeerMusik]

@MeerMusik Thanks. It is just getting more complex for me. Two different group of users have different opinions about / , please help me to fix this issue with a PR. I don't have a windows system and need someone to test it at least 2 version of windows (7, 10 for ex.).

@serayuzgur Sorry I can not help you with that PR as I am being literally still in the preparation Phase to learn Rust.

But I am willing to test whatever "experimental" Version will be provided in whatever way, on my Windows 10 Machine.
Just annouce it in this Issue as you see fit and I will try it out :)

Good Luck!

[mtsr]

I'm not sure the problem is anything to do with the path. This works fine:

Welcome to Node.js v15.14.0.
Type ".help" for more information.
> path.resolve(os.homedir(), ".cargo/")
'C:\\Users\\mtsr\\.cargo'

However, no matter what I do, I get

PS C:\Users\mtsr\.cargo\registry\index\github.com-1ecc6299db9ec823> git show origin/master:fu/tu/futures-lite
fatal: invalid object name 'origin/master'.

which makes total sense, because the repository doesn't even specify a remote.

I'm betting it has something to do with the comment at the top of https://github.com/rust-lang/cargo/blob/58a961314437258065e23cb6316dfc121d96fb71/src/cargo/sources/registry/index.rs where it desribes that it reads directly from the raw git objects.

I'm kind of curious why it works on Mac and Linux, though? A quick test shows that the above git command just works on Mac.

Also, did it work on Windows previously and break, or has it simply never worked?

Maybe a more longterm solution could be to move to libgit2 as well, instead of relying on a git executable. It's always going to a bit cat & mouse, because you're pretty much relying on an internal implementation detail of cargo...

[Samzyre]

@mtsr Yeah it's the error message handling markdown wrong, the error itself seems to come from how git dependencies are indexed by newer versions of cargo (see #126). For the time being I solved by setting localCargoIndexBranch to origin or origin/HEAD, you can also turn local index off for crates altogether.

[mtsr]

Ah yeah, #126 does work.

[serayuzgur]

can you please check 0.5.8

[Samzyre]

I consider this issue closed now since 0.5.9.

[serayuzgur]

👍