Add Deserialize implementation for Bytes
#5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oli-obk
approved these changes
Sep 8, 2017
| fn visit_borrowed_str<E>(self, v: &'de str) -> Result<Bytes<'de>, E> | ||
| where E: Error | ||
| { | ||
| Ok(Bytes::from(v.as_bytes())) |
There was a problem hiding this comment.
Isn't there a default impl forwarding to visit_ borrowed_ bytes?
There was a problem hiding this comment.
@oli-obk visit_borrowed_str docs say that it defauts to visit_str
dtolnay
approved these changes
Sep 8, 2017
|
Thanks! This was an oversight when updating to Serde 1.0. I tweaked the error message in 42c1f08 to be consistent with &str. Otherwise formats that do not support borrowing a byte array will produce unhelpful messages that say unexpected type byte array, expected byte array. Published in serde_bytes 0.10.2. Thanks for the review @oli-obk! |
|
Thanks for the quick release! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
Bytesinstance borrows directly from the input source and as such provides a zero-copy interface.