Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preprocessing.py load_image -> __load_image_from_web #1051

Closed
AndreaLanfranchi opened this issue Feb 28, 2024 · 3 comments
Closed

Preprocessing.py load_image -> __load_image_from_web #1051

AndreaLanfranchi opened this issue Feb 28, 2024 · 3 comments
Labels
bug Something isn't working

Comments

@AndreaLanfranchi
Copy link
Contributor

The condition to load an image from web is that img.startswith("http")
This however is inaccurate as for example file named http_image_from_google.png (considering the path can be relative) would trigger the load from web (not having any chance to be downloaded) while instead should be loaded from cwd

@serengil serengil added the bug Something isn't working label Feb 28, 2024
@serengil
Copy link
Owner

Fair enough

@AndreaLanfranchi
Copy link
Contributor Author

If useful you can extract some hints from my modifications here

@serengil
Copy link
Owner

serengil commented Mar 2, 2024

Closed with PR - #1059

@serengil serengil closed this as completed Mar 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants