Feat task 0203 enhancements #1059
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- if an image starts with http, then it was trying to download from web - to make base64 loading compatible with find, now jpg jpeg png images are accepted.
This was referenced Mar 2, 2024
| @@ -34,7 +34,7 @@ def load_image(img: Union[str, np.ndarray]) -> Tuple[np.ndarray, str]: | |||
| return load_base64(img), "base64 encoded string" | |||
|
|
|||
| # The image is a url | |||
| if img.startswith("http"): | |||
| if img.startswith("http://") or img.startswith("https://"): | |||
There was a problem hiding this comment.
AFAIK python's string comparison is case sensisitve. Hance this might miss upper case HTTP:// and all combinations in between. Maybe transform to lower case before ? (as you seem to don't like regexes)
There was a problem hiding this comment.
morning, you are absolutely right. cheers!
creating an issue to follow this.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tickets
What has been done
With this PR,
1- we were not giving meaningful message if face could not been detected for a given numpy array or base64 encoded image in verify function. this is sorted.
2- in verify function, if one of image pair is having many faces, we were calculating the embedding again and again unncessary.
3- if an image name starts with http, then we were attempting to load it from web
4- in find, we were enforcing images with jpg, jpeg and png but this is not checked for base64 encoded images. to make it compatible, we are now checking type of base64.
5- fastmtcnn detector was throwing error if face could not been detected.
6- stock image of detectors updated.
How to test