fix(core): ScenarioParameters now requires Description to be provided

serenity-js · Jan 2, 2021 · cfa4800 · cfa4800
1 parent 463047b
commit cfa4800
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 5 deletions.
diff --git a/packages/core/src/model/ScenarioParameters.ts b/packages/core/src/model/ScenarioParameters.ts
@@ -7,7 +7,7 @@ export class ScenarioParameters extends TinyType {
     public static fromJSON(o: JSONObject) {
         return new ScenarioParameters(
             Name.fromJSON(o.name as string),
-            o.description && Description.fromJSON(o.description as string),
+            Description.fromJSON(o.description as string),
             (o as any).values,
         );
     }
@@ -20,6 +20,7 @@ export class ScenarioParameters extends TinyType {
         super();
 
         ensure('name', name, isDefined());
+        ensure('description', description, isDefined());
         ensure('values', values, isDefined());
     }
 }
diff --git a/packages/cucumber/spec/gherkin/feature-files/FeatureFileMapper.spec.ts b/packages/cucumber/spec/gherkin/feature-files/FeatureFileMapper.spec.ts
@@ -267,7 +267,7 @@ describe('FeatureFileMapper', () => {
             ));
             expect(outline.parameters[49]).to.equal(new ScenarioParameters(
                 new Name(''),
-                undefined,
+                new Description(''),
                 { parameter: 'value one' },
             ));
 
@@ -291,12 +291,12 @@ describe('FeatureFileMapper', () => {
                 ));
             expect(outline.parameters[60]).to.equal(new ScenarioParameters(
                 new Name(''),
-                undefined,
+                new Description(''),
                 { username: 'admin', password: 'P@ssw0rd1' },
             ));
             expect(outline.parameters[61]).to.equal(new ScenarioParameters(
                 new Name(''),
-                undefined,
+                new Description(''),
                 { username: 'editor', password: 'P@ssw0rd2' },
             ));
 

diff --git a/packages/cucumber/src/gherkin/feature-files/FeatureFileMapper.ts b/packages/cucumber/src/gherkin/feature-files/FeatureFileMapper.ts
@@ -66,7 +66,7 @@ export class FeatureFileMapper {
 
                         const
                             exampleSetName = new Name(examples.name),
-                            exampleSetDescription = examples.description && new Description(examples.description),
+                            exampleSetDescription = new Description(examples.description || ''),
                             variableCells = examples.tableHeader.cells;
 
                         examples.tableBody.forEach(values => {