Clean up serenity::model::prelude
#2429
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
gateway
|
Weird CI failure, I suspect some weird import path in the old prelude was responsible |
arqunis
added
enhancement
arqunis
approved these changes
May 12, 2023
mkrasnitski
added a commit
to mkrasnitski/serenity
that referenced
this pull request
May 18, 2023
Cleans up the model prelude by removing some re-exports, namely: - Don't re-export all the submodules of `model` - Don't re-export 3rd party types that are only used internally - Define the `Color` type alias in `model::colour` - Clean up collisions around `automod::EventType` by not glob-exporting from `guild::automod::*` Note that `guild::audit_log` and `guild::automod` still end up getting re-exported via `guild::*`, but I'm not sure how to address that without manually re-exporting each type from `guild`, which would be annoying.
mkrasnitski
added a commit
to mkrasnitski/serenity
that referenced
this pull request
May 19, 2023
Cleans up the model prelude by removing some re-exports, namely: - Don't re-export all the submodules of `model` - Don't re-export 3rd party types that are only used internally - Define the `Color` type alias in `model::colour` - Clean up collisions around `automod::EventType` by not glob-exporting from `guild::automod::*` Note that `guild::audit_log` and `guild::automod` still end up getting re-exported via `guild::*`, but I'm not sure how to address that without manually re-exporting each type from `guild`, which would be annoying.
mkrasnitski
added a commit
to mkrasnitski/serenity
that referenced
this pull request
May 30, 2023
Cleans up the model prelude by removing some re-exports, namely: - Don't re-export all the submodules of `model` - Don't re-export 3rd party types that are only used internally - Define the `Color` type alias in `model::colour` - Clean up collisions around `automod::EventType` by not glob-exporting from `guild::automod::*` Note that `guild::audit_log` and `guild::automod` still end up getting re-exported via `guild::*`, but I'm not sure how to address that without manually re-exporting each type from `guild`, which would be annoying.
mkrasnitski
added a commit
to mkrasnitski/serenity
that referenced
this pull request
Sep 21, 2023
Cleans up the model prelude by removing some re-exports, namely: - Don't re-export all the submodules of `model` - Don't re-export 3rd party types that are only used internally - Define the `Color` type alias in `model::colour` - Clean up collisions around `automod::EventType` by not glob-exporting from `guild::automod::*` Note that `guild::audit_log` and `guild::automod` still end up getting re-exported via `guild::*`, but I'm not sure how to address that without manually re-exporting each type from `guild`, which would be annoying.
mkrasnitski
added a commit
to mkrasnitski/serenity
that referenced
this pull request
Oct 17, 2023
Cleans up the model prelude by removing some re-exports, namely: - Don't re-export all the submodules of `model` - Don't re-export 3rd party types that are only used internally - Define the `Color` type alias in `model::colour` - Clean up collisions around `automod::EventType` by not glob-exporting from `guild::automod::*` Note that `guild::audit_log` and `guild::automod` still end up getting re-exported via `guild::*`, but I'm not sure how to address that without manually re-exporting each type from `guild`, which would be annoying.
mkrasnitski
added a commit
to mkrasnitski/serenity
that referenced
this pull request
Oct 24, 2023
Cleans up the model prelude by removing some re-exports, namely: - Don't re-export all the submodules of `model` - Don't re-export 3rd party types that are only used internally - Define the `Color` type alias in `model::colour` - Clean up collisions around `automod::EventType` by not glob-exporting from `guild::automod::*` Note that `guild::audit_log` and `guild::automod` still end up getting re-exported via `guild::*`, but I'm not sure how to address that without manually re-exporting each type from `guild`, which would be annoying.
arqunis
pushed a commit
to arqunis/serenity
that referenced
this pull request
Oct 24, 2023
Cleans up the model prelude by removing some re-exports, namely: - Don't re-export all the submodules of `model` - Don't re-export 3rd party types that are only used internally - Define the `Color` type alias in `model::colour` - Clean up collisions around `automod::EventType` by not glob-exporting from `guild::automod::*` Note that `guild::audit_log` and `guild::automod` still end up getting re-exported via `guild::*`, but I'm not sure how to address that without manually re-exporting each type from `guild`, which would be annoying.
arqunis
pushed a commit
to arqunis/serenity
that referenced
this pull request
Oct 24, 2023
Cleans up the model prelude by removing some re-exports, namely: - Don't re-export all the submodules of `model` - Don't re-export 3rd party types that are only used internally - Define the `Color` type alias in `model::colour` - Clean up collisions around `automod::EventType` by not glob-exporting from `guild::automod::*` Note that `guild::audit_log` and `guild::automod` still end up getting re-exported via `guild::*`, but I'm not sure how to address that without manually re-exporting each type from `guild`, which would be annoying.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cleans up the model prelude by removing some re-exports, namely:
modelColortype alias inmodel::colourautomod::EventTypeby not glob-exporting fromguild::automod::*Note that
guild::audit_logandguild::automodstill end up getting re-exported viaguild::*, but I'm not sure how to address that without manually re-exporting each type fromguild, which would be annoying.