Make model items accessible via serenity::model::ITEM
instead of serenity::model::MODULE::ITEM
#2419
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2394
This PR is backwards-compatible, except for renaming model::Error to ModelError
This PR consists of two commits:
The first commit is more important. The second commit serves to clean up long paths within serenity and express that using the new short path is recommended for new code.
The second commit is very huge, though, and manually reviewing all its changes is infeasible. If wanted, I can re-do that commit and record my screen. The review work would be reduced to checking the regexes I used. I would also be okay with cutting out the second commit entirely, if that is preferred. If we do keep the second commit, we should add it to .git-blame-ignore-revs