Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return insertion #130

Merged
merged 5 commits into from
Jul 19, 2013
Merged

Return insertion #130

merged 5 commits into from
Jul 19, 2013

Conversation

serge-sans-paille
Copy link
Owner

This PR should fix Issue #77 , the hard way :-)

Previous implementation had typing information spread over several files
(bad locality) and did not handle using member function on the none
type.
@serge-sans-paille
Copy link
Owner Author

@joker-eph I took into account all your remarks, thanks for the careful review.

* This fixes Issue #77
* The CFG does not take into account interprocedural exceptions
Increase the number of sampling when testing random generator
implementation, to avoid false negative.

Execution time is still reasonable compared to compile time ;-)
clang++ is not capable of resolving against the right constructor for

    core::list<empty_list>({ proxy::list{}() })

so help it a little.
@pbrunet
Copy link
Collaborator

pbrunet commented Jul 19, 2013

it is ok for me. @joker-eph what about you?

@joker-eph
Copy link
Collaborator

Still a comment waiting in the first commit.

joker-eph pushed a commit that referenced this pull request Jul 19, 2013
@joker-eph joker-eph merged commit 206d0f3 into master Jul 19, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants