Fix bad allocation of slopes #1320
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -206,7 +207,7 @@ void do_interp(const T1 &dz, const T2 &dx, const T3 &dy, T4 &dres, | |||
|
|
|||
| /* only pre-calculate slopes if there are relatively few of them. */ | |||
| if (lenxp <= lenx) { | |||
| auto slope_vect = std::vector<double>(lenxp - 1); | |||
| slope_vect = std::vector<npy_double>(lenxp - 1); | |||
There was a problem hiding this comment.
you probably just want a resize(lenxp -1) here
|
Done, done and done! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.