-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Core mapping - Admin Page #2970
Conversation
Hello @lebaphi - the PlayWright testing is currently failing for this. That's quite understandable, since so much as changed. So, I suggest we (well, you ;-) ) change the CI workflow to comment out the PlayWright testing until this branch is mature, then we will reinstate it. |
Nice work so far @lebaphi 😀 |
@IanMayo Do you think we should change the 'Delete' icon to '...' icon. And we can have 2 actions (Delete / Duplicate) for each renderer . So that, we can create duplicated renderer and edit properties which we want to change. So it save time for creating. |
Thanks @Tristina1788 - that's a good idea, but we currently only have the two renderers and don't expect them to be duplicated. Let's defer the suggestion for the future. |
EditProps._selection_cannot_saved_with_true.mp4 |
I've just done some testing @lebaphi - it's looking good. Note: for the Oh, and there should be a For string and enum properties there should be a string |
@lebaphi User role with 'View Props' = false, 'Edit/Remove Feature' = false, 'Move/Resize Feature' = false, user still can see props and edit/remove , move/resize feature permission-viewprops_edit-remove.features.mp4 |
Thanks for the @Tristina1788 . I'll start off on the failure to use the props permission. The mapping permissions may require some trickery we haven't done before (allowing a user to move features from one force but not the other). |
@lebaphi I see some conflicts. Please resolve them then I can check it. |
@lebaphi I got error when run |
2024-07-25_15-22-52.mp4
2024-07-25_17-07-14.mp4 |
Hi @Tristina1788 , URL is Url Template in this link https://leafletjs.com/reference.html#tilelayer, about Max Native Zoom, I think @IanMayo can help 😄 |
@lebaphi - I'm pretty sure the URL (and maybe maximum zoom) values from the channel should replace these hard-coded values: |
|
Great, @lebaphi - could you take these values from the channel definition instead please? |
2024-07-26_19-35-33.mp4 |
Hi @Tristina1788, can you check it again on your side, maybe incognito browser? It seems to work on my side Screen.Recording.2024-07-26.at.8.36.17.PM.mov |
@lebaphi I checked on incognitor and the issue still happens. Please uncheck permission for 'Red Force' with 'Move/Resize Feature' = False, 'Edit Pros' = false and check again for Umpire user. |
@lebaphi @IanMayo I can't update force property can.t.update.force.mp4Steps:
|
2024-08-02_05-52-14.mp4
Steps:
More details on video : 2024-08-02_06-00-45.mp4 |
HI @Tristina1788, user need to have 'View Props' permission to view the item's properties. Items are only visible on the mapping table when 'View Spatial' permission is set to true |
@lebaphi @IanMayo yes, I mean that. But at that time, I 'm wrong the case . Here is the video for that issue. No-show-property-When-has-ViewProperty-_acc-RED-view-Blue_.mp4Anyway, it's fixed now.
2024-08-04_17-23-10.mp4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It works as expected now.
Fixes #2971