Develop #156
Merged
Develop #156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Overall new-style tables are now supported, but bugs related to corner cases still remain - Fixed and reorganized test files a bit (still a mess overall) - `debug` function moved from .`tools` to `.utils`, so it can be imported from modules that depend on `.tools` (it has no dependencies so utils is the natural place to put it) - Table-related elements moved from `elements.py` to `table_elements.py`, as the SLOC was getting quite large in that module. - Renamed `_decode_ica()` to `decode_ica()`, as the function is not really exposed externally
- All tests pass - Fixed several small corner cases
…comparing existing json files
Update run_tests.yml
|
This PR adds support for Pandoc 2.11.1 The code for creating tables is quite messy, sp. compared to everything else, so I'm not yet 100% sure that there are no corner cases that trigger errors. For instance, what if a table has a table body with an intermediate table head, but no content? Also, most Pandoc elements are simple in that they just contain other elements plus attributes (like an url, title, etc.). But a table object is much more complex. |
ickc
approved these changes
Nov 9, 2020
There was a problem hiding this comment.
Merging for now. There's some instances that a valid pandoc AST would not be parsed correctly, either from json to panflute AST, or vice versa. c.f. the test files in #142 (comment)
I'll test it more tomorrow and I think it is very close now. Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.