Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LPS-59592 #2645

Closed
wants to merge 182 commits into from
Closed

LPS-59592 #2645

wants to merge 182 commits into from

Conversation

hhuijser
Copy link

No description provided.

pavel-savinov and others added 30 commits October 26, 2015 10:26
@pavel-savinov
LPS-59803 use selectFolder action name to maintain consistent breadcr…
074fd25 
…umb entries
@ealonso
LPS-59803 Uses the mvcPath
b65a0d2
@ealonso
LPS-59803 Adds container fluid class
b1f9820
@ealonso
LPS-59803 Adds btn-lg class to the buttons
e7f9916
@ealonso
LPS-59803 Adapt to lexicon
5a041da
@brianchandotcom
LPS-59116 Serve RTL CSS resources for RTL languages
250be34
@arbetts @brianchandotcom
LPS-59478 use established actionableDynamicQuery pattern in indexers …
1da7902 
…where possible
@BryanEngler @brianchandotcom
LPS-59478 SF
93e33af
@jonathanmccann @brianchandotcom
LPS-59478 Remove unnecessary cast
620698d
@brianchandotcom
LPS-59478 SF
d182619
@brandizzi @brianchandotcom
LPS-55808 Only get live group id if scope group is staging
d8b3e3f
@pavel-savinov @brianchandotcom
LPS-59270 show trash entries max age property in minutes as it appear…
77f97cf 
…s in default properties file and user guides
@pavel-savinov @brianchandotcom
LPS-59270 save trash entries max age property in minutes without conv…
e39ce5e 
…ersion
@pavel-savinov @brianchandotcom
LPS-59270 show appropriate help message for trash entries max age, mi…
ea5eade 
…nutes instead of days
@brianchandotcom
LPS-59270 lang keys
3f5d95e
@brandizzi @brianchandotcom
LPS-59828 Declare web upgrade service type
c2e6fc0
@hhuijser @brianchandotcom
LPS-59622 remove calls to *ServiceUtil in polls-api
ed90c85
@hhuijser @brianchandotcom
LPS-59622 remove calls to *ServiceUtil in polls-service
63ab1d1
@adolfopa @brianchandotcom
LPS-59830 Ignore invalid repositories in the UI
27a08d8
@brianchandotcom
LPS-59281 These 2 attributes are no longer supported by the taglib be…
3bb21e9 
…cause they need to be used by taglibs vertical-card-footer and vertical-card-header
@brianchandotcom
LPS-59281 Escaping should be last in the line, so we should do escapi…
09122aa 
…ng in the taglib. We only do it in title and subtitle because others may contain html (like header and footer)
@brianchandotcom
LPS-59281 All these cases don't need to be escaped since the taglib i…
26de158 
…s already doing it. They were working because the taglib was unescaping them before escaping them.
@ealonso @brianchandotcom
LPS-59657 Adds style to make the image responsive
5776032
@brianchandotcom
LPS-59644 Create JSON object using better API
cd52b8a
@brianchandotcom
LPS-59670 /document_library/upload_file_entry should only map to Uplo…
a05e714 
…adFileEntryMVCActionCommand
@brianchandotcom
LPS-59675 Delegate expects a function not a string
dd59aa4
@ealonso @brianchandotcom
LPS-59804 Don't show article toolbar and workflow messages for defaul…
bcc229c 
…t values
@jbalsas @brianchandotcom
LPS-59808 Set default placeholder value
9b78ab5
@brianchandotcom
LPS-59808 wordsmith
40e36cb
@brianchandotcom
LPS-59808
5061e74
Sergio Gonzalez and others added 23 commits October 26, 2015 20:24
@brianchandotcom
LPS-59223 This jspf shouldn't be included since it was necessary for …
a377837 
…the feature of moving pages between nodes that we no longer support
@brianchandotcom
LPS-59223 Simplify and unify command names
cd1dd9f
@izaera @brianchandotcom
LPS-59223 Extend implementation of AlwaysAllowDoAsUser to support mvc…
ebf895c 
…RenderCommandNames
@izaera @brianchandotcom
LPS-59223 Split commands into separate classes
9522f32
@izaera @brianchandotcom
LPS-59223 Fix "move to recycle bin" link in wiki page details tab
ff5fa98
@izaera @brianchandotcom
LPS-59223 SF
82c96aa
@izaera @brianchandotcom
LPS-59223 Make tests compile
39b3f2d
@brianchandotcom
LPS-59223 Sort
4c5d5a4
@brianchandotcom
LPS-59223 SF
ba93885
@brianchandotcom
LPS-59223 Sort
07371be
@brianchandotcom
LPS-59223 See document-library-web
2fc9c28
@brianchandotcom
LPS-59223 use helper method
e1e5730
@brianchandotcom
LPS-59223 sort
d6ea600
@brianchandotcom
LPS-59223 See documentlibrary-web
c3c3c33
@brianchandotcom
LPS-59223 Why do we need 3 of these
dab8ac5
@brianchandotcom
LPS-59223 See DLDisplayViewMVCRenderCommand
7636066
@brianchandotcom
LPS-59223 avoiding the word "Default\ since we don't use that anywher…
9762559 
…e else
@brianchandotcom
LPS-59223 avoiding the word "Default\ since we don't do that anywhere…
4003434 
… else
@brianchandotcom
LPS-59223 SF
bf33598
@lesliewong92 @brianchandotcom
LRQA-18741 Modify file separator of output directory name if running …
92488e1 
…on windows
@brianchandotcom
LRQA-18741 SF
d724e0c
@hhuijser
LPS-59592 remove calls to *ServiceUtil in wiki-service
61c9bd8
@hhuijser
LPS-59592 remove calls to *ServiceUtil in wiki-web
77620ee
@hhuijser
Copy link
Author

Hey @sergiogonzalez

You mentioned you were still doing stuff on wiki. I see some commits came in yesterday and I was doing another batch of autofixing stuff, so I thought I'd send you what I got... Let me know if you want me to resend later...

@sergiogonzalez
Copy link
Owner

Hey @hhuijser

Perfect timing!. We finished moving the Wiki to MVC so we are ready to merge this.

Thanks!

@sergiogonzalez
Copy link
Owner

Just started reviewing :)

:octocat: Sent from GH.

@liferay-continuous-integration
Copy link
Collaborator

Some tests FAILED!

Build Time: 37 minutes 1 second

Base Branch:

Branch Name: master
Branch GIT ID: d724e0cbe672d03e639d052eef0c0f291f2c3859

Job Summary:

For more details click here.

Failed Jobs:

  1. test-portal-acceptance-pullrequest(master)
    Job Results:

    16 Jobs Passed.
    7 Jobs Failed.

    Completed with the status of FAILURE.
  2. test-portal-acceptance-pullrequest-batch(master)/modules-integration-db2
    Job Results:

    3886 Tests Passed.
    2 Tests Failed.

    1. WikiActivityInterpreterTest.testActivityInterpreter
    2. PortalLogAssertorTest.testScanXmlLog
  3. test-portal-acceptance-pullrequest-batch(master)/modules-integration-hypersonic
    Job Results:

    3886 Tests Passed.
    2 Tests Failed.

    1. WikiActivityInterpreterTest.testActivityInterpreter
    2. PortalLogAssertorTest.testScanXmlLog
  4. test-portal-acceptance-pullrequest-batch(master)/modules-integration-mysql
    Job Results:

    3886 Tests Passed.
    2 Tests Failed.

    1. WikiActivityInterpreterTest.testActivityInterpreter
    2. PortalLogAssertorTest.testScanXmlLog
  5. test-portal-acceptance-pullrequest-batch(master)/modules-integration-oracle
    Job Results:

    3886 Tests Passed.
    2 Tests Failed.

    1. WikiActivityInterpreterTest.testActivityInterpreter
    2. PortalLogAssertorTest.testScanXmlLog
  6. ...

@sergiogonzalez
Copy link
Owner

Pull request submitted to brianchandotcom#31471.

:octocat: Sent from GH.

@hhuijser hhuijser deleted the LPS-59592 branch March 1, 2016 04:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone