Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LPS-69436 Set a title. When the entry is in trash, user will se a message saying "flags-are-disabled-because-this-entry-is-in-the-recycle-bin" #3787

Closed
wants to merge 24 commits into from
Closed

LPS-69436 Set a title. When the entry is in trash, user will se a message saying "flags-are-disabled-because-this-entry-is-in-the-recycle-bin" #3787

wants to merge 24 commits into from

Conversation

jbalsas
Copy link

@jbalsas jbalsas commented Feb 13, 2017 •
edited by sergiogonzalez

Hey @sergiogonzalez, @ambrinchaudhary, I'm sending this over to fix the breaking change we introduce by changing the base class in FlagsTag.java.

The accepted solution would be to keep the old class there, as deprecated and create a new one as internal, pointing the tld to it.

ambrinchaudhary and others added 24 commits February 13, 2017 11:54
@ambrinchaudhary @jbalsas
LPS-69436 Create metal component for Flags
d62371b
@ambrinchaudhary @jbalsas
LPS-69436 Not clicable if the entry is in Trash
4156298
@ambrinchaudhary @jbalsas
LPS-69436 Remove old markup
47f0893
@ambrinchaudhary @jbalsas
LPS-69436 Use a div to wrap the template so we avoid rendering it twice
20b47b9
@ambrinchaudhary @jbalsas
LPS-69436 Use Soy template rendered taglib
c0fc2de
@ambrinchaudhary @jbalsas
LPS-69436 SF
fcccd0f
@ambrinchaudhary @jbalsas
LPS-69436 Add shrinkwrap
3ec10f5
@ambrinchaudhary @jbalsas
LPS-69436 Add JSDoc
b4860e0
@ambrinchaudhary @jbalsas
LPS-69436 Add missing dependency
d3e2deb
@ambrinchaudhary @jbalsas
LPS-69436 Update metal dependencies
8f6dcd2
@ambrinchaudhary @jbalsas
LPS-69436 Add template description
76f6c2f
@ambrinchaudhary @jbalsas
LPS-69436 Extend from TemplateRendererTag
6d71c7e
@ambrinchaudhary @jbalsas
LPS-69436 Remove js folder
b33016f
@ambrinchaudhary @jbalsas
LPS-69436 Use released artifact
ea60268
@ambrinchaudhary @jbalsas
LPS-69436 Update shrinkwrap
7d05826
@ambrinchaudhary @jbalsas
LPS-69436 Add missing dependency
9d62bb0
@ambrinchaudhary @jbalsas
LPS-69436 SF
15decaa
@ambrinchaudhary @jbalsas
LPS-69436 Baseline
e4b3e69
@jbalsas
LPS-69436 SF
56ad2c2
@jbalsas
LPS-69436 SF
7baf722
@jbalsas
LPS-69436 SF
38ebb5b
@jbalsas
LPS-69436 Always send label even though it might not be set or it mig…
e2c38bd 
…ht be false.
@jbalsas
LPS-69436 Same for message
320876f
@ambrinchaudhary @jbalsas
LPS-69436 Set a title. When the entry is in trash, user will se a mes…
c5a1e6e 
…sage saying "flags-are-disabled-because-this-entry-is-in-the-recycle-bin"
@jbalsas jbalsas mentioned this pull request Feb 13, 2017
Closed
@liferay-continuous-integration
Copy link
Collaborator

Some tests FAILED.

Build Time: 1 hour 12 minutes 18 seconds

Base Branch:

Branch Name: master
Branch GIT ID: 9408e27a5be704c45b6d19b40841a46da29815fa

Job Summary:

For more details click here.

Failed Jobs:

  1. test-portal-acceptance-pullrequest(master)
    Job Results:

    96 Jobs Passed.
    2 Jobs Failed.

    prepare-poshi-runner-properties:
     [exec] Using proxy squid.lax.liferay.com:3128.
  2. test-portal-acceptance-pullrequest-batch(master)/modules-compile-jdk8
    Job Results:

    0 Tests Passed.
    1 Test Failed.

    1. test-portal-acceptance-pullrequest-batch(master) ?? 0,!master #69463
           [exec] :private:apps:foundation:portal-cache:portal-cache-ehcache-ee-provider:jarSources
     [exec] :private:apps:foundation:portal-cache:portal-cache-ehcache-ee-provider:assemble
     [exec] 
     [exec] BUILD FAILED
     [exec] 
     [exec] Total time: 12 mins 20.896 secs
     [exec] Gradle build finished at 2017-02-13 16:17:58.430
     [exec] 
     [exec] FAILURE: Build failed with an exception.
     [exec] 
     [exec] * What went wrong:
     [exec] Execution failed for task ':sdk:gradle-plugins-soy:compileJava'.
     [exec] > Compilation failed; see the compiler error output for details.
     [exec] 
     [exec] * Try:
     [exec] Run with --info or --debug option to get more log output.
     [exec] 
     [exec] * Exception is:
     [exec] org.gradle.api.tasks.TaskExecutionException: Execution failed for task ':sdk:gradle-plugins-soy:compileJava'.
     [exec] 	at org.gradle.api.internal.tasks.execution.ExecuteActionsTaskExecuter.executeActions(ExecuteActionsTaskExecuter.java:84)
     [exec] 	at org.gradle.api.internal.tasks.execution.ExecuteActionsTaskExecuter.execute(ExecuteActionsTaskExecuter.java:55)
     [exec] 	at org.gradle.api.internal.tasks.execution.SkipUpToDateTaskExecuter.execute(SkipUpToDateTaskExecuter.java:62)
For upstream results, click here.

@sergiogonzalez
Copy link
Owner

Pull request submitted to jbalsas#690. See changes here.

:octocat: Sent from GH.

@jbalsas jbalsas deleted the pr-682 branch April 3, 2017 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@jbalsas @liferay-continuous-integration @sergiogonzalez @ambrinchaudhary