Raise test coverage #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seriema
force-pushed
the
chore-44-raise-test-coverage
branch
from
73db7b5
to
11fa90f
Compare
From 97.2% to 100%. * Removed unnecessary guard clauses in things I borrowed from AngularJS source code (mostly for IE8 support). * Used $filter instead of manually removing elements from array in removeFallback(). * Disable video and screenshots on SauceLabs as the tests aren't visual. * Added tests to better flex the query handling feature in #23. ** Testing array of objects. ** Undefined and empty URL param values. ** Date-type in params object. Closes #44
seriema
force-pushed
the
chore-44-raise-test-coverage
branch
from
11fa90f
to
3a430f4
Compare
We used Date.prototype.toISOString(), which wasn’t supported on IE8. Reference: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global _Objects/Date/toISOString Fixes #51
seriema
force-pushed
the
chore-44-raise-test-coverage
branch
from
3a430f4
to
3a1ac50
Compare
Empty/undefined query param values won’t be included in the mock data file path. They were inconsistent anyway. Fixes #48
| @@ -68,7 +69,28 @@ angular.module('apiMock', []) | |||
| return keys; | |||
| } | |||
|
|
|||
| // Taken from Angular 1.4.x: https://github.com/angular/angular.js/blob/f13852c179ffd9ec18b7a94df27dec39eb5f19fc/src/Angular.js#L296 | |||
| // TODO: IE8: remove when we drop IE8/Angular 1.2 support. | |||
There was a problem hiding this comment.
The hint is right there in the comment: we support Angular 1.2. So then we need to support whatever browsers it supports, which includes IE8.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From 97.2% to 100%.
source code (mostly for IE8 support).
removeFallback().
Closes #44
Fixes #51, #48