Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Date in URL's were breaking on IE8 #51

Closed
seriema opened this issue Oct 18, 2015 · 0 comments
Closed

Date in URL's were breaking on IE8 #51

seriema opened this issue Oct 18, 2015 · 0 comments
Labels
bug
Milestone
0.3.x

Comments

@seriema
Copy link
Owner

seriema commented Oct 18, 2015

While working on #44 I noticed we weren't testing "date in URL query param" properly so we didn't see that it never worked on IE8.

Travis build failure with SauceLabs on IE8: https://travis-ci.org/seriema/angular-apimock/builds/86030580

Related: #50
@seriema seriema added the bug label Oct 18, 2015
@seriema seriema added this to the 0.3.x milestone Oct 18, 2015
seriema added a commit that referenced this issue Oct 18, 2015
@seriema
fix(apimock): dates were broken in IE8
3a430f4 
We used Date.prototype.toISOString(), which wasn’t supported on IE8.

Reference:
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global
_Objects/Date/toISOString

Fixes #51
seriema added a commit that referenced this issue Oct 18, 2015
@seriema
fix(apimock): toISOString support on dates in IE8
3a1ac50 
We used Date.prototype.toISOString(), which wasn’t supported on IE8.

Reference:
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global
_Objects/Date/toISOString

Fixes #51
@seriema seriema mentioned this issue Oct 18, 2015
Merged
@seriema seriema mentioned this issue Oct 24, 2015
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
0.3.x
Development

No branches or pull requests
1 participant
@seriema