This repository has been archived by the owner on Jun 1, 2024. It is now read-only.
Expose interface-typed options via appsettings #162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Merged, thanks for the PR. |
mivano
added a commit
that referenced
this pull request
Apr 21, 2018
* Explain use of `AutoRegisterTemplateVersion` in the README (#157) It took me a while to figure out that the reason the sink failed to start with a somewhat cryptic "Failed to execute" error was that, while I had updated all libraries to ES6-compatibile versions, I had not set the `AutoRegisterTemplateVersion` option and so the template sent was not ES6-compatible (it used "string"). This PR explains this snag in the readme. For a future PR, would it make sense to deprecate the manual option and automatically detect the ES version when attempting to register a template? It can be fetched by a GET request at the root URL, which returns: ``` { "name" : "8hV7EYy", "cluster_name" : "docker-cluster", "cluster_uuid" : "bC1bTjVuTiyWoaprIIZIIw", "version" : { "number" : "6.2.1", "build_hash" : "7299dc3", "build_date" : "2018-02-07T19:34:26.990113Z", "build_snapshot" : false, "lucene_version" : "7.2.1", "minimum_wire_compatibility_version" : "5.6.0", "minimum_index_compatibility_version" : "5.0.0" }, "tagline" : "You Know, for Search" } ``` * Added some explanation See #165 * Render message by default #158, Could disable MessageTemplate #159 + Tests (#160) * Updated readme * Expose interface-typed options via appsettings (#162) * Expose interface-typed settings via appsettings * Amend readme to show changes for json appsettings as well * Updated changelog
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What issue does this PR address?
161
Does this PR introduce a breaking change?
No