Skip to content
This repository was archived by the owner on Jun 1, 2024. It is now read-only.
This repository was archived by the owner on Jun 1, 2024. It is now read-only.

ElasticsearchJsonFormatter should set render message to true by default #158

@klettier

Description

@klettier

Does this issue relate to a new feature or an existing bug?

  • Bug
  • New Feature

What version of Serilog.Sinks.Elasticsearch is affected? Please list the related NuGet package.

  • All

What is the target framework and operating system? See target frameworks & net standard matrix.

  • All

Please describe the current behavior?

When I'm calling WriteTo.Elasticsearch without providing any CustomFormatter in ElasticsearchSinkOptions it will create a formatter with property renderMessage set to true see here.

If I'm providing my own instance of ElasticsearchJsonFormatter I have to be aware of that behavior to avoid losing my message property because the default behavior is to set renderMessage to false see here

Please describe the expected behavior?

I think we should be consistent here and set renderMessage to true by default in the constructor of ElasticsearchJsonFormatter

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions