Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat async sinks #149

Merged
merged 39 commits into from
Oct 22, 2021
Merged

Feat async sinks #149

merged 39 commits into from
Oct 22, 2021

Conversation

EngRajabi
Copy link
Contributor

In this version, the project has been updated to the latest versions
Also added to netstandard 2.1
In this version, the sinks mode is used async(use PeriodicBatchingSink)

merbla and others added 24 commits July 1, 2016 14:25
…ameterAdded

Added QueueLimit parameter and passing to base PeriodicBatchingSink
…the default specified in PeriodicBatchingSinkOptions.QueueLimit
…ameterAdded

BoundedConcurrentQueue does not accept a negative queue limit. Using …
@EngRajabi
Copy link
Contributor Author

Because the sdk is 2.2 during the old build. The build breaks down

@EngRajabi
Copy link
Contributor Author

@merbla
please check it
Bild is successful. Only vs should be updated to the 2019 version

@EngRajabi
Copy link
Contributor Author

build success. 👍
@merbla

@merbla
Copy link
Contributor

merbla commented Oct 21, 2021

Thanks @EngRajabi LGTM, just a few items on comments etc.

Copy link
Contributor

@merbla merbla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you update the comments and I think this should be good to go.

Copy link
Contributor Author

@EngRajabi EngRajabi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approve

@EngRajabi EngRajabi requested a review from merbla October 21, 2021 11:11
@merbla merbla merged commit d09ab46 into serilog-contrib:dev Oct 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants