Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port Serilog to support ASP.NET vNext #283

Merged
merged 1 commit into from
Nov 23, 2014
Merged

Conversation

kanchanm
Copy link
Contributor

This PR includes - source code changes to port Serilog to support ASP.NET vNext (includes support for console, file, system.diagnostics to start with), smoke test updates. This also includes a temporary Demo project to show all the above features working on vNext. The Serilog.vs2015 solution is created SxS which includes the new projects as well so that people can still open the original solution without issues on VS 2013

@kanchanm kanchanm changed the title This PR includes - source code changes to port Serilog to support ASP.NET vNext Port Serilog to support ASP.NET vNext Nov 12, 2014
@khellang
Copy link
Member

What's "vs2015" and how do we get it? 😉

@nblumhardt
Copy link
Member

Awesome, thank you Kanchan!

@nblumhardt
Copy link
Member

Some notes on building from the email thread.

To build you will need to do the following -

  1.  Call `msbuild Serilog-aspnetcore50.kproj /p:ProduceOutputsOnBuild=True`
    
  2.  Reference the output assemblies in the existing .nuspec file:
    
<file src="artifacts\bin\Serilog\Debug\aspnet50\Serilog.dll" target="lib\aspnet50" />
<file src="artifacts\bin\Serilog\Debug\aspnet50\Serilog.xml" target="lib\aspnet50" />
<file src="artifacts\bin\Serilog\Debug\aspnetcore50\Serilog.dll" target="lib\aspnetcore50" />
<file src="artifacts\bin\Serilog\Debug\aspnetcore50\Serilog.xml" target="lib\aspnetcore50" />

Same as above for FullNetFx..

@kanchanm
Copy link
Contributor Author

Here you go.. you can install VS 2015 Preview from here :-)
http://www.microsoft.com/en-us/download/details.aspx?id=44934

Note, the PR above was based off CTP4 packages. Now that preview is out I will send an update which references these packages.

ASP.NET vNext (includes support for console, file, system.diagnostics to
start with), smoke test updates. This also includes a temporary Demo
project to show all the above features working on vNext. The
Serilog.vs2015 solution is created SxS which includes the new projects as
well so that people can still open the original solution without issues on
VS 2013.
@kanchanm
Copy link
Contributor Author

Updated the PR for preview bits.

@khellang
Copy link
Member

Already had it on my machine 😉 Was just wondering why the name was out in the open all of a sudden 😝

@kanchanm
Copy link
Contributor Author

:-)

@nblumhardt
Copy link
Member

Installing the preview now.... :)

@nblumhardt
Copy link
Member

Merged to dev in 559da76 - it's taken us a while to shift our CI process to a public (AppVeyor) account, so hopefully the way is paved now for us to get some builds happening with ASP.NET 5 supported (or at the worst, I'll build the binaries by hand and embed them in the NuPkg until we have it sorted end-to-end).

Cheers!!

@nblumhardt nblumhardt merged commit 1e62438 into serilog:master Nov 23, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants