Add ConfigurationDependencyAttribute to help with referenced assemblies ...

[augustoproiete]

… not being copied over.

As per discussion on #880

[codecov-io]

Current coverage is 73.68% (diff: 100%)

Merging #898 into dev will increase coverage by 0.04%

@@                dev       #898   diff @@
==========================================
  Files            69         70     +1   
  Lines          3195       3200     +5   
  Methods         695        697     +2   
  Messages          0          0          
  Branches        358        358          
==========================================
+ Hits           2353       2358     +5   
  Misses          672        672          
  Partials        170        170          

Powered by Codecov. Last update 9dd1be8...5c5f5e2

[nblumhardt]

I still think Serilog.Settings.ConfigurationDependencyAttribute is a more self-describing name and namespace for the type. The attribute is only likely to be used in conjunction with XML or JSON settings, so focusing it on that scenario has some discoverability benefits even if it could be used for other purposes.

[nblumhardt]

Dependent, to me, is the thing that "does-the-depending" (i.e. the inverse direction). Maybe Dependency?

[nblumhardt]

A type from the assembly that is used dynamically.

[augustoproiete]

@nblumhardt PR amended based on your comments

[nblumhardt]

Looks good, thanks @caioproiete.

I wondered for a moment if DependencyType might be an instance of Hungarian notation, but on consideration, the Type may not be the actual Dependency. Any thoughts on this?

[augustoproiete]

I wondered for a moment if DependencyType might be an instance of Hungarian notation, but on consideration, the Type may not be the actual Dependency. Any thoughts on this?

No strong feelings there. The Type suffix seems commonly used for property exposing a Type (1, 2, 3, 4, ...).

But yes, the Type is not really the dependency... The dependency is the assembly and in an ideal world, we would like to do something like [ConfigurationDependencyAttribute(typeof(SinkName).Assembly)] but, of course, that doesn't work on attributes.

[nblumhardt]

👍 let's stick with DependencyType.

Need to investigate #880 a little further before merging, but LGTM here.

[augustoproiete]

Bug fixed with most recent version of ReSharper.