refactor(editor): restructure plugins config API #654
hejtfulchecks.yml
on: pull_request
Cache of yarn matches checksums in lockfile
2m 56s
Build succeeds
45s
All source files are well formated with prettier
50s
TypeScript compiles
45s
ESLint has no errors
41s
Jest integration tests
1m 12s
Run cypress tests (locally)
1m 53s
Run cypress tests (with docker build)
1m 32s
Annotations
7 errors and 8 warnings
|
Build succeeds
Process completed with exit code 1.
|
|
TypeScript compiles:
src/frontend/editor.tsx#L25
Property 'customPlugins' does not exist on type 'SerloEditorProps'.
|
|
TypeScript compiles:
src/frontend/editor.tsx#L34
Type '{ children: (editor: BaseEditor) => Element; pluginsConfig: PluginsConfig; customPlugins: any; initialState: { plugin: string; } & { state?: unknown; }; }' is not assignable to type 'IntrinsicAttributes & SerloEditorProps'.
|
|
TypeScript compiles:
src/frontend/plugins/plugins-config.ts#L4
Type '{ box: { allowedPlugins: string[]; }; multimedia: { explanation: { plugin: EditorPluginType; config: { allowedPlugins: EditorPluginType[]; }; }; allowedPlugins: string[]; }; spoiler: { ...; }; table: { ...; }; general: { ...; }; }' is not assignable to type 'PluginsConfig'.
|
|
TypeScript compiles:
src/frontend/serlo-editor.tsx#L51
Type '{ document: { plugin: string; } & { state?: unknown; }; customPlugins: ({ type: string; plugin: EditorPlugin<StringStateType, SerloInjectionConfig>; renderer: (props: EditorSerloInjectionDocument) => Element; visibleInSuggestions: boolean; icon: Element; } | { ...; })[]; }' is not assignable to type 'IntrinsicAttributes & SerloRendererProps'.
|
|
TypeScript compiles
Process completed with exit code 2.
|
|
Run cypress tests (with docker build)
The process '/usr/local/bin/yarn' failed with exit code 1
|
|
ESLint has no errors
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, actions/setup-node@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
|
Build succeeds
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, actions/setup-node@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
|
TypeScript compiles
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, actions/setup-node@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
|
All source files are well formated with prettier
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, actions/setup-node@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
|
Jest integration tests
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, actions/setup-node@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
|
Run cypress tests (with docker build)
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, actions/setup-node@v3, cypress-io/github-action@v5. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
|
Run cypress tests (locally)
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, actions/setup-node@v3, cypress-io/github-action@v5. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
|
Cache of yarn matches checksums in lockfile
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, actions/setup-node@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|