Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed theme dependencies #7

Merged
merged 1 commit into from
Oct 15, 2020
Merged

Fixed theme dependencies #7

merged 1 commit into from
Oct 15, 2020

Conversation

JianLoong
Copy link
Contributor

This PR is to handle #6

I think I found your problem with it. Basically, what happened was, the project was using this theme as a git submodule and because it was updated, it seem to have broken something. At first I thought it was because of the Hugo version as well.

What I have done is, instead of using it as submodule I included all the theme files needed to generate your blog in the themes directory. I am also using an older version of the theme (A version before they introduced SCSS dated December 2019). This way the site will not break so during any more updates of that theme as well.

It seems to be working on my local machine using Hugo v0.75.1.

Hopefully this helps you out. 😃

@zo0o0ot
Copy link
Contributor

zo0o0ot commented Oct 8, 2020

I tried starting your branch in GitPod. Good news: no more error! Bad news: it still doesn't seem to show the images in the posts.

Version of Hugo in GitPod:
Hugo Static Site Generator v0.68.3/extended linux/amd64 BuildDate: 2020-03-25T06:15:45Z

Is the img shortcode broken?

@zo0o0ot
Copy link
Contributor

zo0o0ot commented Oct 8, 2020

An example of an existing page:
image

Hugo server running in GitPod:
image

Are you seeing the image when running locally?

@JianLoong
Copy link
Contributor Author

I was just looking at GitPod, it seems the reason this happens because of the URL generated for preview purposes.

So if you actually did a

hugo server or hugo server -D

to run it, it will not look nice because that is supposed to be for development. If you look at the generated files under public would be correct but the demo itself is not working on GitPod because it is mapped to localhost instead of the live url instead.

That being said, I tried to run the command below on GitPod instead

hugo server -b https://1313-c40017b2-ba54-4783-9c76-73b58c0603ba.ws-us02.gitpod.io -D --appendPort=false

and it seems to be working fine. (You will need to put the correct url in the command for it to be working)

What is happening here is that I specifically ask it generated with that base url without appending the port number.

Screenshot from 2020-10-08 17-39-33

Do tell me if this works. 😌

@zo0o0ot
Copy link
Contributor

zo0o0ot commented Oct 15, 2020

I'm going to merge this, because I can always revert the commit later.

@zo0o0ot zo0o0ot merged commit af39b52 into sermonarchives:master Oct 15, 2020
@zo0o0ot
Copy link
Contributor

zo0o0ot commented Oct 15, 2020

To be clear, preview images seem to be working fine, it was the images that were in posts that were missing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants