better error messages: provide node names #274
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Won't it make sense to include the node name into higher level error constructors (namely |
|
Ah yes, that'd probably be a better option! |
printing what node caused an error is very useful for debugging build or deployment failures, especially when deploying to several nodes at the same time
PhilTaken
force-pushed
the
phil/node-name-in-errors
branch
from
5150525
to
e7638a7
Compare
|
I added the node name information to revokations as well, thought that might be just as useful |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
printing what node caused an error is very useful for debugging build or deployment failures, especially when deploying to several nodes at the same time
closes #273