Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude the non-working versions of haskell-src-meta #24

Open
Martoon-00 opened this issue Nov 29, 2022 · 0 comments
Open

Exclude the non-working versions of haskell-src-meta #24

Martoon-00 opened this issue Nov 29, 2022 · 0 comments
Labels
bug Something isn't working

Comments

@Martoon-00
Copy link
Member

Clarification and motivation

Looks like recent releases of haskell-src-meta do not support the recent versions of template-haskell properly. See haskell-party/haskell-src-meta#40.

We have to exclude the non-working versions properly, as in LTS-20.1 currently, interpolator does not work.

Acceptance criteria

  • With all the haskell-src-meta versions after the one last checked (which is 0.8.9) tests pass or we forbid building with such a version.
@Martoon-00 Martoon-00 added the bug Something isn't working label Nov 29, 2022
Martoon-00 added a commit that referenced this issue Apr 28, 2023
Problem: it turned out that the code for GHC extensions conversion that
we use from `haskell-src-meta` now does not handle the recently added
extensions, and on attempt to use the new LTS our interpolator fails
with pattern match error.

See #24 for
details.

Solution: use `spoon` to catch the pattern match failure.

Motivation: since the issued `haskell-src-meta` package version is
already on Hackage, there is not much we can do right now. Moreover,
some people wait for nyan-interpolation to work with the recent LTS.

So let's make it work at least somehow. I don't want to copy-paste the
canvas of code that `fromExtension` is, so I just use `teaspoon` to
catch the cases of extensions unhandled by `fromExtension` and ignore
them. As result, the most recent exceptions remain unsupported for now.

Separately I will try to fix `haskell-src-meta` and to make all the
extensions work the user will just need to bump their `haskell-src-meta`
dependency.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant