[#20] Test with the more recent GHC #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Martoon-00
force-pushed
the
martoon/bump-base
branch
from
72146e0
to
3838f45
Compare
|
Hello! |
|
Hey! Thanks for the attention to this library! |
Problem: there is a demand in using this package with the recent GHCs, like GHC-9.2.4. And generally, we must periodically switch to the most recent LTS and GHC. Solution: add the quite recent GHC-9.2.7 version to CI build matrix. LTS version has been bumped just recently to lts-19.33, and I don't want to bump it further because there might be difficulties when using too fresh releases. We will probably add the recent LTS to the CI build matrix instead some later.
Problem: we have bumped the version bounds for some deps, but didn't make a release yet. Solution: bump package version to 0.9.1 to next make a release.
Problem: it turned out that the code for GHC extensions conversion that we use from `haskell-src-meta` now does not handle the recently added extensions, and on attempt to use the new LTS our interpolator fails with pattern match error. See #24 for details. Solution: use `spoon` to catch the pattern match failure. Motivation: since the issued `haskell-src-meta` package version is already on Hackage, there is not much we can do right now. Moreover, some people wait for nyan-interpolation to work with the recent LTS. So let's make it work at least somehow. I don't want to copy-paste the canvas of code that `fromExtension` is, so I just use `teaspoon` to catch the cases of extensions unhandled by `fromExtension` and ignore them. As result, the most recent exceptions remain unsupported for now. Separately I will try to fix `haskell-src-meta` and to make all the extensions work the user will just need to bump their `haskell-src-meta` dependency.
Problem: core subpackage has a changelog, but it's in a draft state. Solution: fix it to start from the `0.9` version, and also add changes for `0.9.1`.
Martoon-00
force-pushed
the
martoon/bump-base
branch
from
3838f45
to
7fa2737
Compare
|
I'm sorry for the delay. Just uploaded the 0.9.1 versions to hackage. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Make sure that the package builds with one of the most recent GHCs.
Related issue(s)
Partially resolves #20
Resolves #26
✅ Checklist for your Pull Request
Related changes (conditional)
Tests
silently reappearing again.
Documentation
Public contracts
of Public Contracts policy.
and
Stylistic guide (mandatory)