This repository has been archived by the owner on Jan 15, 2024. It is now read-only.
Print & exit if only installed pkgs #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tarkah
commented
Apr 20, 2023
Comment on lines
+20
to
-30
| import moss.client.cli : MossCLI; | ||
| import moss.client.cli : initialiseClient; | ||
| import moss.client.statedb; | ||
| import moss.client.ui; | ||
| import moss.deps.registry; | ||
| import std.stdio : writefln, writef, writeln; | ||
| import std.algorithm : map, filter; | ||
| import std.array : array; | ||
| import std.experimental.logger; | ||
| import std.file : exists; | ||
| import std.range : empty; | ||
| import std.stdio : writefln, writef, writeln; | ||
| import std.string : join, wrap, format, endsWith; | ||
| import std.algorithm : map, filter; | ||
| import moss.client.ui; | ||
| import moss.client.statedb; | ||
| import moss.client.cli : MossCLI; | ||
| import std.file : exists; |
There was a problem hiding this comment.
I've sorted imports, but I can disregard in the future
ermo
approved these changes
Apr 20, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #29
Currently
installdoesn't check if final transaction state is comprised of only "installed" packages. This fixes the issue by only applying the transaction if there's >=1 package not currently installed.If no new packages exist, the list of user provided packages already installed will be printed and exit.
As seen below, if user provides both installed & uninstalled packages, it'll only list new packages and carry on w/ the transaction. If user provides only installed packages, it'll print them and exit.