Units for theoretical_pitch are in Hz

[pelinski]

Hi! @marinaniet0 and I realized this while working in the Audio and Muisc Processing Lab assignment:

In line 73:

                        theoretical_pitch = Converter.cent_to_hz(
                            note_cent, tonic_hz)

So theoretical_pitch must be in Hz when written to the stable_notesdict.

[codecov]

Codecov Report

Merging #128 (5cc452e) into master (10e94bc) will not change coverage.
The diff coverage is 100.00%.

@@          Coverage Diff           @@
##           master    #128   +/-   ##
======================================
  Coverage    0.40%   0.40%           
======================================
  Files          46      46           
  Lines        5000    5000           
======================================
  Hits           20      20           
  Misses       4980    4980           

Impacted Files	Coverage Δ
src/tomato/audio/notemodel.py	0.00% <ø> (ø)
src/tomato/__init__.py	100.00% <100.00%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 10e94bc...5cc452e. Read the comment docs.

[sertansenturk]

Thank you @pelinski and @marinaniet0 not only for reporting the issue but also for making the fix! 🥳

Before I approve the PR can you also do the following:

• Increment the version to v0.14.2 in package init.py
• Add the new version and a brief explanation to the changelog
• Last and most important. Can you add yourselves to the Contributors? 😄

Thanks in advance!

[pelinski]

Done! Thank you for considering the PR and for the toolbox :-)

[sertansenturk]

My pleasure. I'm glad that whatever I did years ago is of some help to you people :)

FYI, Before hitting the merge I've realized that the automated tests are failing. It's not because of your change, but something irrelevant. I've changed the PR to merge to the dev branch so I can fix these problems before pushing to master and creating a problematic release 😄

Thanks for the contributions!

[sertansenturk]

linting borken on Python. It's my problem.

Merging to dev so I can fix these on my own before merging to master.

Thanks!

The base branch was changed.