Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Units for theoretical_pitch are in Hz #128

Merged
merged 4 commits into from
Mar 19, 2021
Merged

Units for theoretical_pitch are in Hz #128

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f5b71c3
corrected cent to Hz
pelinski Mar 19, 2021
fba0113
updated version
pelinski Mar 19, 2021
6dceb87
added version v0.14.2
pelinski Mar 19, 2021
5cc452e
added Marina Nieto and Teresa Pelinski
pelinski Mar 19, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion CONTRIBUTORS
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,4 +3,6 @@ Andrés Ferraro aferraro AT dcodesoft DOT com
Miguel García Casado miguel DOT garciac AT upf DOT edu
- bug fixes
Mogens Lundholm mogens AT lundholm.org
- mu2 to musicXML conversion binaries
- mu2 to musicXML conversion binaries
Marina Nieto marina DOT nieto01 AT estudiant DOT upf DOT edu
Teresa Pelinski teresa DOT pelinski01 AT estudiant DOT upf DOT edu
3 changes: 3 additions & 0 deletions Changelog.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,8 @@
# Changelog

## tomato v0.14.2
- Fix ``theoretical_pitch`` units in ``NoteModel`` class (Pull request [#128](https://github.com/sertansenturk/tomato/pull/128))

## tomato v0.14.1

- Bump lxml from 4.4.2 to 4.6.2 (Pull request [#127](https://github.com/sertansenturk/tomato/pull/127))
Expand Down
2 changes: 1 addition & 1 deletion src/tomato/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
__version__ = "0.14.1"
__version__ = "0.14.2"
2 changes: 1 addition & 1 deletion src/tomato/audio/notemodel.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@ def _stable_pitches_to_notes(self, stable_pitches_hz,
"theoretical_interval": {"value": note_cent,
"unit": "cent"},
"theoretical_pitch": {"value": theoretical_pitch,
"unit": "cent"},
"unit": "Hz"},
"stable_pitch": {"value": stable_pitch_hz,
"unit": "Hz"}}
break
Expand Down