Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Serval DNA C code uses ambiguous types #11

Closed
gardners opened this issue Sep 11, 2012 · 3 comments
Closed

Serval DNA C code uses ambiguous types #11

gardners opened this issue Sep 11, 2012 · 3 comments
Assignees
@quixotique
Labels
effort:hours mantis

Comments

@gardners
Copy link
Member

We use "long long" etc instead of things like uint_64t

Mantis severity: minor
Mantis priority: normal
Mantis project: Core Project
Product version: 0.09 Shiny
Can reproduce: N/A
@ghost ghost assigned quixotique Sep 11, 2012
@gardners
Copy link
Member Author

Originally reported as mantis:0000165 at Tue Apr 3 15:52:11 2012.

@quixotique
Copy link
Member

Issue migrated from Mantis to GitHub with Mantis status assigned and resolution open at Tue Sep 11 17:29:01 2012 using sp-mantis2github version 0.91

quixotique added a commit that referenced this issue Oct 6, 2013
@quixotique
Issue #11: replace long long with int64_t
ffafae8
quixotique added a commit that referenced this issue Oct 7, 2013
@quixotique
Issue #11: uint16_t instead of short for TCP port number
7a8d750
quixotique added a commit that referenced this issue Oct 7, 2013
@quixotique
Issue #11: uint16_t instead of unsigned short for URI port number
1c96164
quixotique added a commit that referenced this issue Oct 8, 2013
@quixotique
Issue #11: use socklen_t instead of int where appropriate
9ba08e4 
Also check for valid recvaddrlen before processing a received MDP packet.
quixotique added a commit that referenced this issue Oct 8, 2013
@quixotique
Issue #11: fix printf "%zd" ssize_t warnings on Android
2119433 
Also use ssize_t instead of 'int' in a few suitable places
quixotique added a commit that referenced this issue Oct 11, 2013
@quixotique
Issue #11: Use rhizome_filehash_t everywhere
974c7a5
quixotique added a commit that referenced this issue Oct 11, 2013
@quixotique
Issue #11: improve types in file i/o functions
97cbebc 
Use open(2)/read(2)/write(2) instead of fopen(3)/fread(3)/fwrite(3) in
several places to avoid unnecessary buffering

Fix a bug in Rhizome HTTP add's handling of unconfigured manifest
template file

Improve some debug and error logging for file i/o
quixotique added a commit that referenced this issue Jul 10, 2014
@quixotique
Issue #11: remove unnecessary long long
e2d8ca1
@quixotique
Copy link
Member

There are no longer any uses of long long except where required to invoke the NaCl API or system or standard library calls. Issue #73 fixed most if not all signed vs unsigned bugs, and the changes pulled from #70 and subsequent work on warnings will help prevent any type unsafe code from creeping in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@quixotique quixotique

Labels
effort:hours mantis
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gardners @quixotique