Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

init setting-ui #40

Merged
merged 2 commits into from
Feb 6, 2023
Merged

init setting-ui #40

merged 2 commits into from
Feb 6, 2023

Conversation

xsahxl
Copy link
Contributor

@xsahxl xsahxl commented Feb 3, 2023

Signed-off-by: xsahxl xsahxl@126.com

Signed-off-by: xsahxl <xsahxl@126.com>
@xsahxl xsahxl requested a review from heimanba February 3, 2023 13:41
@@ -0,0 +1,41 @@
{
"name": "@serverless-cd/auth-setting",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个命名不对哈,不是 auth相关的, 就叫setting-ui

Signed-off-by: xsahxl <xsahxl@126.com>
@xsahxl xsahxl changed the title init auth-setting init setting-ui Feb 6, 2023
Copy link
Member

@heimanba heimanba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@heimanba heimanba merged commit f0961c4 into serverless-cd:main Feb 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants